Fix provider destroy function to properly cleanup connections (#394) #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ket#394) Previously, destroy() would temporarily change status but the provider would continue living, firing unwanted events and causing memory leaks. The websocketClose handler would trigger reconnection even during graceful shutdown. This fix ensures proper cleanup by setting status to OFFLINE before closing the websocket, clearing timers, and waking pending reconnection attempts. Also adds a guard in websocketClose to only reconnect if status is not OFFLINE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, destroy() would temporarily change status but the provider would continue living, firing unwanted events and causing memory leaks. The websocketClose handler would trigger reconnection even during graceful shutdown.
This fix ensures proper cleanup by setting status to OFFLINE before closing the websocket, clearing timers, and waking pending reconnection attempts. Also adds a guard in websocketClose to only reconnect if status is not OFFLINE.
Fixes #394